-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sending MultiPart in http client Fix #1005 #1876
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing the changes, I came to the conclusion that this needs a deeper API change to work efficiently with the non-class streams of vibe-core. What I would propose is to drop the MultiPart(BodyPart)' class(es) completely and change the signature of
writePartto
void writePart(InputStream)(InputStream content, in ref InetHeaderMap headers = emptyHeaderMap) if (isInputStream!InputStream)`. That would avoid the need for a proxy that does dynamic dispatch and destroys all inlining possibilities.
Of course there can still be the convenience overloads that take other kinds of types for content
.
@s-ludwig ping |
@s-ludwig pong |
@s-ludwig bump... I need this yet again... |
This comment has been minimized.
This comment has been minimized.
ping |
Any plans on merging this? @s-ludwig |
bump @s-ludwig
|
this is also testing the server implementation which made me find #1875